feat: improve and complete alloy prelude crate feature flag compatiblity
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-prelude-crate Breaking changes: flags / exports
This was referenced Mar 29, 2024
zerosnacks
commented
Mar 29, 2024
Comment on lines
-131
to
-132
| transport-http-reqwest = ["dep:reqwest", "alloy-transport-http?/reqwest"] | ||
| transport-http-hyper = ["alloy-transport-http?/hyper"] |
There was a problem hiding this comment.
breaking change, now uses reqwest and hyper top level definitions
There was a problem hiding this comment.
Optionally we could mark these as deprecated instead of removing them outright
This was referenced Mar 29, 2024
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
zerosnacks
changed the title
alloy prelude crate feature flag compatiblityalloy prelude crate feature flag compatiblity
mattsse
approved these changes
Mar 29, 2024
zerosnacks
commented
Mar 29, 2024
|
|
||
| # alloy | ||
| default-tls = ["reqwest?/default-tls"] | ||
| jsonrpsee-types = ["alloy-rpc-types?/jsonrpsee-types", "alloy-rpc-engine-types?/jsonrpsee-types"] |
There was a problem hiding this comment.
breaking change, renamed to rpc-types-json
zerosnacks
commented
Mar 29, 2024
|
|
||
| # alloy | ||
| default-tls = ["reqwest?/default-tls"] |
There was a problem hiding this comment.
breaking change, now part of reqwest flag
|
how will this interact with #379? I'd prefer to merge that one first as it is smaller |
I've pulled in the latest changes, there were no breaking changes. I've added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #391, has a mirror PR for
alloy/exampleshere: alloy-rs/examples#39Solution
Fixes:
pubsubfeature onalloy-providerwhen usingprovider-wsorprovider-ipcrpc-client-ws,rpc-client-ipcas feature flags.native-keccakflag that was not re-exported fromalloy/core.stdas a default feature but supportno_stdreqwestandhyperas top-level definitions and apply torpc-clientandtransportreqwestas default featureserdefeature flagPR Checklist