Adds check -Zcheck-cfg job
#419
Conversation
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
|
Also, I think we should make the |
crates/provider/src/builder.rs
Outdated
| #[cfg(feature = "hyper")] | ||
| pub fn on_hyper_http(self, url: url::Url) -> Result<L::Provider, TransportError> | ||
| where | ||
| L: ProviderLayer<RootProvider<N, BoxTransport>, N, BoxTransport>, | ||
| N: Network, | ||
| { | ||
| let client = ClientBuilder::default().hyper_http(url); | ||
| let client = ClientBuilder::default().hyper_http(url).boxed(); |
There was a problem hiding this comment.
I don't think this should be boxed
There was a problem hiding this comment.
@prestwich Unsure why but adding these features forced the ProviderBuilder::on_client(&self, client: RpcClient) to only accept RpcClient
Yes it shouldn't.
There was a problem hiding this comment.
oh I just saw this in #379 and was confused about it 🤔
There was a problem hiding this comment.
i think what happened is that the blocks were previously entirely non-functional, and therefore were written incorrectly and we didn't notice (because they were non-functional and never checked by the compiler). Now that the cfg blocks are effective, a compiler warning appears. I'll fix in #379 in a second
Added here: #421 |
|
@yash-atreya would you rebase now that #379 is in? |
Yeah I'll take care of it |
Motivation
Ref: #416
And fixes: #416 (comment)
Solution
Adds
reqwestandhyperfeatures inalloy-provider.@prestwich Unsure why but adding these features forced the
ProviderBuilder::on_client(&self, client: RpcClient<T>)to only acceptRpcClient<BoxTransport>PR Checklist