Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle 4844 fee #412

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat: handle 4844 fee #412

merged 2 commits into from
Mar 27, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Mar 27, 2024

blocked by #411

ref #403

closes #377

This is not ideal but this at least sets a blob fee value for 4844 txs (txs with a sidecar)

This is not ideal for a few reasons:

  • This does not estimate an appropriate blob fee and instead uses the value of the next block, if blob space is congested this will not result in timely inclusion (to do this we really need eth_feeHistory)
  • Once all clients serve blob fee data in eth_feeHistory this can all be done with one eth_feeHistory request

I think we should consider customizing the gas layer so a custom estimator can be configured

cc @anna-carroll

@mattsse mattsse marked this pull request as ready for review March 27, 2024 23:29
@mattsse mattsse merged commit c22b9dd into main Mar 27, 2024
17 checks passed
@mattsse mattsse deleted the matt/add-handle-4844 branch March 27, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Populate 4844 gas in FillTxLayer and GasEstimationLayer
2 participants