Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe blob transaction sidecar #400

Closed
prestwich opened this issue Mar 26, 2024 · 2 comments · Fixed by #401
Closed

Dedupe blob transaction sidecar #400

prestwich opened this issue Mar 26, 2024 · 2 comments · Fixed by #401

Comments

@prestwich
Copy link
Member

Can we proactively dedupe this as part of this PR?

current code in RPC types is as follows

/// This represents a set of blobs, and its corresponding commitments and proofs.
#[derive(Clone, Debug, PartialEq, Eq, Hash, Default, Serialize, Deserialize)]
#[repr(C)]
pub struct BlobTransactionSidecar {
    /// The blob data.
    pub blobs: Vec<Blob>,
    /// The blob commitments.
    pub commitments: Vec<Bytes48>,
    /// The blob proofs.
    pub proofs: Vec<Bytes48>,
}

Originally posted by @prestwich in #361 (comment)

@mattsse
Copy link
Member

mattsse commented Mar 26, 2024

kzg validation only works with kzg bytes and blob types.

we can dedup but this means we have c-kzg dep no longer optional because we need the sidecar for all things rpc, we could however remove the sidecar type with c-kzg and transmut when calling validate? so that we don't use c-kzg types at all

@prestwich
Copy link
Member Author

Kzg validation shouldn't occur unless the kzg feature flag is on, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants