fix: correctly process chainId field #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
onbjerg
reviewed
Mar 22, 2024
| let serialized = serde_json::to_string(&transaction).unwrap(); | ||
| assert_eq!( | ||
| serialized, | ||
| r#"{"hash":"0x0000000000000000000000000000000000000000000000000000000000000001","nonce":"0x2","blockHash":null,"blockNumber":null,"transactionIndex":null,"from":"0x0000000000000000000000000000000000000006","to":null,"value":"0x8","gas":"0xa","input":"0x0b0c0d"}"# |
There was a problem hiding this comment.
that's just a fixture from the test above with all options set to None, the idea was to test that we can handle any of the optional fields missing
I can change it to a valid legacy tx payload so we avoid unexpected test failures when modifying Transaction in the future
mattsse
approved these changes
Mar 22, 2024
Comment on lines
72
to
74
| #[serde(default)] | ||
| #[serde(with = "alloy_serde::u64_hex_opt")] | ||
| #[serde(skip_serializing_if = "Option::is_none")] |
There was a problem hiding this comment.
can we collapse them into a single serde attribute?
the skip is also fine because this field should be ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
WIthout
serde(default)legacy transactions without chainId field can't be deserialized right nowSolution
PR Checklist