Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the cow #34

Merged
merged 4 commits into from
Nov 18, 2023
Merged

fix: remove the cow #34

merged 4 commits into from
Nov 18, 2023

Conversation

prestwich
Copy link
Member

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

gakonst
gakonst approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good w me. @onbjerg you may need to adjust your PR.

@onbjerg
Copy link
Member

onbjerg commented Nov 18, 2023

will adjust when we end up rebasing, low prio rn since this doesn't affect the public API

onbjerg
onbjerg approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm also

@prestwich prestwich merged commit d6bd18b into main Nov 18, 2023
17 checks passed
@DaniPopes DaniPopes deleted the prestwich/no-cow branch November 18, 2023 02:18
@prestwich prestwich mentioned this pull request Nov 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst gakonst approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prestwich @onbjerg @gakonst @DaniPopes