Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alloy-rpc-types serde_helpers mod to standalone crate alloy-serde #259

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

moricho
Copy link
Contributor

@moricho moricho commented Mar 10, 2024

Motivation

Closes: #123

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@moricho moricho marked this pull request as ready for review March 10, 2024 08:57
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this, the rpc-types crate is already quite big and if we add network specific types, a standalone this crate will be useful

wdyt @DaniPopes

Comment on lines 1 to 2
//! Alloy serde helpers for primitive types.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs the regular alloy lib.rs header:

#![doc(
html_logo_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/alloy.jpg",
html_favicon_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/favicon.ico"
)]
#![warn(
missing_copy_implementations,
missing_debug_implementations,
missing_docs,
unreachable_pub,
clippy::missing_const_for_fn,
rustdoc::all
)]
#![cfg_attr(not(test), warn(unused_crate_dependencies))]
#![deny(unused_must_use, rust_2018_idioms)]
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at 👉 3c784c4

@moricho moricho requested a review from mattsse March 12, 2024 04:49
@mattsse mattsse merged commit e4612eb into alloy-rs:main Mar 12, 2024
15 checks passed
@moricho moricho deleted the serde-helper branch March 12, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Move alloy-rpc-types serde_helpers mod to standalone crate
2 participants