-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move alloy-rpc-types
serde_helpers
mod to standalone crate alloy-serde
#259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this, the rpc-types crate is already quite big and if we add network specific types, a standalone this crate will be useful
wdyt @DaniPopes
crates/serde/src/lib.rs
Outdated
//! Alloy serde helpers for primitive types. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs the regular alloy lib.rs header:
alloy/crates/rpc-types/src/lib.rs
Lines 6 to 20 in b370cf3
#![doc( | |
html_logo_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/alloy.jpg", | |
html_favicon_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/favicon.ico" | |
)] | |
#![warn( | |
missing_copy_implementations, | |
missing_debug_implementations, | |
missing_docs, | |
unreachable_pub, | |
clippy::missing_const_for_fn, | |
rustdoc::all | |
)] | |
#![cfg_attr(not(test), warn(unused_crate_dependencies))] | |
#![deny(unused_must_use, rust_2018_idioms)] | |
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed at 👉 3c784c4
Motivation
Closes: #123
Solution
PR Checklist