-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signer
): sign dynamic typed data
#235
feat(signer
): sign dynamic typed data
#235
Conversation
…_typed_data_sync to Signer trait to support Signers that are not Sized
…e; remove clone() on domain arg to TypedData::from_struct
…rde::Serialize trait to FooBar
…arent Cargo.toml to signer's Cargo.toml
… from TypedData.eip712_signing_hash()
Fixed issues with the formatting. It looks like the CI tests are failing because of a compilation issue:
I don't believe I made any changes that caused this. Anything I need to should be doing to fix this @DaniPopes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Missing just formatting.
…ic_typed_data_sync
@DaniPopes Fixed! Thanks for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a rebase (sorry about that), otherwise lgtm
… and private_key.rs to reflect changes from upstream
@onbjerg Thanks for the review. I believe I resolved all of the merge conflicts. |
signer
): sign dynamic typed datasigner
): sign dynamic typed data
Motivation
Resolves issue #202.
Solution
Add methods
sign_dynamic_typed_data
andsign_dynamic_typed_data_sync
to theSigner
andSignerSync
traits, respectively.PR Checklist