-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus
): add extra EIP-4844 types needed
#229
Conversation
506ca6b
to
ac624f6
Compare
consensus
): add extra EIP-4844 types neededconsensus
): add extra EIP-4844 types needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the enum approach is the most straight forward one imo.
though we still want an actual type for the 4844+blob variant
5d629db
to
c30d0bc
Compare
309a2d0
to
6a9c619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the cfg on the type itself is not pretty.
I think we should try to limit kzg feature to validation.
we should be able to use primitive types for the blob fields instead and not kzg types here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nits
now that we're limiting c-kzg to validation, we can make this no default :)
bb49c64
to
6e300ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Evalir let's rename to |
clippy failure unrelated. |
Motivation
We still need to add a few
EIP-4844
types to be able to properly send and decode full EIP-4844 txs with a sidecar. Right now we can't do that, and theTxEip4844
contained in the envelope is incomplete, as it misses the sidecar.Solution
Add the needed types. Closes #231
PR Checklist