feat: Add parent beacon block root into ExecutionPayloadEnvelopeV3
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
clabby
force-pushed
the
cl/ecotone-envelope-payload
branch
from
b509f2a
to
57fff8b
Compare
DaniPopes
requested changes
Feb 21, 2024
Co-authored-by: DaniPopes <[email protected]>
DaniPopes
approved these changes
Feb 21, 2024
Evalir
approved these changes
Feb 21, 2024
mattsse
approved these changes
Feb 21, 2024
Comment on lines
+120
to
+122
| /// Optimism-specific - Ecotone parent beacon block root | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub parent_beacon_block_root: Option<B256>, |
There was a problem hiding this comment.
I'm fine with that for now, if you create a new reth issue for better rpc execution payload customization
cc @Rjected
There was a problem hiding this comment.
is this fixed with the customized engine types in node builder?
|
@clabby to update reth please bump pinned alloy commit in paradigm/emv-inspectors first, then bump both on reth |
mattsse
pushed a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Feb 21, 2024
## Overview Updates `alloy-rpc-types` and `alloy-rpc-trace-types` to `76c70fb9d44ace661bbf33408c2527e3874c964e`, which contains alloy-rs/alloy#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the
parentBeaconBlockRootfield to theExecutionPayloadEnvelopeV3, required in theEcotonehardfork.Reference: https://github.com/ethereum-optimism/op-geth/blob/70103aa6866c3d965f1f71154958cd9c1a7beb5b/beacon/engine/types.go#L102-L103