Add try_spawn function for Anvil and Geth bindings
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 24, 2024
crates/node-bindings/src/anvil.rs
Outdated
Comment on lines
72
to
74
| /// Spawning the anvil process failed. | ||
| #[error("couldnt start anvil")] | ||
| Spawn, |
There was a problem hiding this comment.
this should also include the wrapped io error
There was a problem hiding this comment.
fixed at: bcdf7f8
crates/node-bindings/src/anvil.rs
Outdated
| @@ -313,6 +346,107 @@ impl Anvil { | |||
| chain_id: self.chain_id.or(chain_id), | |||
| } | |||
| } | |||
|
|
|||
| /// Consumes the builder and spawns `anvil`. If spawning fails, returns an error. | |||
| #[track_caller] | |||
There was a problem hiding this comment.
Suggested change
| #[track_caller] |
mattsse
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
|
@mattsse |
mattsse
requested changes
Mar 7, 2024
|
Added the above change in 037a15f |
mattsse
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #136
Solution
PR Checklist