Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Use impl Future in return position in PubSubConnect #200

Closed
DaniPopes opened this issue Feb 9, 2024 · 0 comments · Fixed by #218
Closed

[Feature] Use impl Future in return position in PubSubConnect #200

DaniPopes opened this issue Feb 9, 2024 · 0 comments · Fixed by #218
Labels
enhancement New feature or request

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Feb 9, 2024 •
edited
Loading

Component

providers, pubsub

Describe the feature you would like

This trait does not need to be object-safe, and it is not currently, so there is no point in boxing the futures if we can make use of 1.75's features.

Trait implementations should also be updated to use "async fn".

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use impl Future in PubSubConnect alloy-rs/alloy
1 participant
@DaniPopes