feat: temporary provider trait #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
onbjerg/alloy-temp-provider-trait
branch
from
342e2d9 to
9a060cd
Compare
onbjerg
force-pushed
the
onbjerg/alloy-temp-provider-trait
branch
from
6b8901b to
b32a3d8
Compare
prestwich
reviewed
Nov 18, 2023
onbjerg
force-pushed
the
onbjerg/alloy-temp-provider-trait
branch
from
f597612 to
0702253
Compare
* fix: serialize block num w/o leading zeros * fix: use `u64` for block numbers
* workaround * fix: actual fix * fix: actual fix part 2
* workaround * fix: actual fix * fix: actual fix part 2 * fix access list keys --------- Co-authored-by: Enrique Ortiz <[email protected]>
* chore: start removing cows * chore: uncow tempProvider * Apply suggestions from code review Co-authored-by: DaniPopes <[email protected]> * switch to single element tuple --------- Co-authored-by: DaniPopes <[email protected]>
* feat(): raw_request * chore: remove unneeded async block
Evalir
force-pushed
the
onbjerg/alloy-temp-provider-trait
branch
from
0ccb869 to
bc87178
Compare
Evalir
force-pushed
the
onbjerg/alloy-temp-provider-trait
branch
from
bc87178 to
1d825ec
Compare
7 tasks
DaniPopes
requested changes
Dec 18, 2023
crates/providers/src/provider.rs
Outdated
| Self: Sync; | ||
|
|
||
| #[cfg(feature = "anvil")] | ||
| async fn set_code(&self, address: Address, code: &'static str) -> TransportResult<()> |
There was a problem hiding this comment.
AnvilProvider extension trait? instead of cfg in this trait
| where | ||
| Self: Sync; | ||
|
|
||
| async fn raw_request<P, R>(&self, method: &'static str, params: P) -> TransportResult<R> |
There was a problem hiding this comment.
Do we need this in the trait? Because it breaks object safety unless Self:Sized
There was a problem hiding this comment.
Need it for the RPC cheatcode—maybe we could add an extension trait for this too?
| @@ -36,6 +113,131 @@ pub struct LegacyTransactionRequest { | |||
| pub chain_id: Option<u64>, | |||
| } | |||
|
|
|||
| impl Encodable for LegacyTransactionRequest { | |||
There was a problem hiding this comment.
Should this even implement rlp traits? This is the same as encode_fields
There was a problem hiding this comment.
IMO we should remove these RLP impls—we originally did this to migrate cast but decided against it later. RLP-able types should go on the alloy-consensus-types crate
| len += self.gas_limit.length(); | ||
| len += self.kind.length(); | ||
| len += self.value.length(); | ||
| len += self.input.0.length(); |
There was a problem hiding this comment.
this can be in the derive macro and the method in encodable trait
| /// | ||
| /// See [Self::encode_for_signing] for more information on the encoding format. | ||
| pub fn signature_hash(&self) -> B256 { | ||
| let mut buf = bytes::BytesMut::with_capacity(self.payload_len_for_signature()); |
| @@ -49,6 +251,175 @@ pub struct EIP2930TransactionRequest { | |||
| pub access_list: AccessList, | |||
| } | |||
|
|
|||
| impl Encodable for EIP2930TransactionRequest { | |||
| fn encode(&self, out: &mut dyn BufMut) { | |||
| self.chain_id.encode(out); | |||
| @@ -63,6 +434,183 @@ pub struct EIP1559TransactionRequest { | |||
| pub access_list: AccessList, | |||
| } | |||
|
|
|||
| impl Encodable for EIP1559TransactionRequest { | |||
| fn encode(&self, out: &mut dyn BufMut) { | |||
* chore: remove self: sync from defs * chore: remove most generics * chore: default for BlockId * chore: remove unnecesary reassignment * chore: auto impl on mut/rc * chore: unnecesary assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I am currently migrating Foundry to use Alloy's providers instead of Ether's middleware. To make migration easier later on when we have the final API down I am introducing a temporary trait for the current
Providerstruct.Additionally, some RPC methods were either incomplete or missing.
Solution
Todo
PR Checklist
Depends on #28