feat: extend FeeHistory type with eip-4844 fields #188
Conversation
allnil
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
crates/rpc-types/src/eth/fee.rs
Outdated
| /// of the returned range, because this value can be derived from the newest block. Zeroes | ||
| /// are returned for pre-EIP-4844 blocks. | ||
| pub base_fee_per_blob_gas: Vec<U256>, | ||
| /// An array of block blob gas used ratios. These are calculated as the ratio of gasUsed and | ||
| /// gasLimit. | ||
| pub blob_gas_used_ratio: Vec<f64>, |
There was a problem hiding this comment.
these need to be option for now, because only supported after cancun
and skip if none
There was a problem hiding this comment.
Should be enough: #[serde(default, skip_serializing_if = "Vec::is_empty")]
There was a problem hiding this comment.
these need to be option for now, because only supported after cancun
and skip if none
The spec says just to fill with 0s for pre-cancun blocks, would this not be ok even with cancun not activated?
There was a problem hiding this comment.
That's if the network and RPC provider implements the EIP/Cancun
There was a problem hiding this comment.
There was a problem hiding this comment.
that's both for base_fee_per_blob_gas and blob_gas_used_ratio or only for blob_gas_used_ratio?
Related to reth task: paradigmxyz/reth#6330
according to: ethereum/execution-apis#486