Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Subscription broadcast buffer size is fixed #170

Closed
mattsse opened this issue Feb 1, 2024 · 0 comments · Fixed by #177
Closed

[Feature] Subscription broadcast buffer size is fixed #170

mattsse opened this issue Feb 1, 2024 · 0 comments · Fixed by #177
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Feb 1, 2024

Component

providers, pubsub

Describe the feature you would like

The buffer size for subscriptions is currently a constant.

impl ActiveSubscription {
/// Create a new active subscription.
pub(crate) fn new(request: SerializedRequest) -> (Self, broadcast::Receiver<Box<RawValue>>) {
let local_id = request.params_hash();
let (tx, rx) = broadcast::channel(16);

This should be configurable.

we should add settings for the

pub(crate) struct PubSubService<T> {

so you can call connect(connector, settings)

wdyt @prestwich

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant