fix: handle IPC unreadable socket #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
mattsse
force-pushed
the
matt/handle-ipc-eof
branch
from
8c597ff
to
9917290
Compare
Evalir
approved these changes
Jan 31, 2024
prestwich
reviewed
Jan 31, 2024
crates/transport-ipc/src/lib.rs
Outdated
| @@ -196,6 +196,14 @@ where | |||
| Ok(data_len) => { | |||
| debug!(%data_len, "Read data from IPC socket"); | |||
|
|
|||
| if data_len == 0 { | |||
There was a problem hiding this comment.
mild preference to make this an Ok(0) match arm
gakonst
approved these changes
Jan 31, 2024
| // stream is no longer readable and we're also unable to decode any more | ||
| // data. This happens if the IPC socket is closed by the other end. | ||
| // so we can return `None` here. | ||
| debug!("IPC socket EOF, stream is closed"); |
There was a problem hiding this comment.
would consider making these traces
There was a problem hiding this comment.
can do eventually, but for now this is useful on debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case when the ipc socket is no longer readable and poll read returns Ready(0), in which case we can terminate the stream.
This happens when the node is terminated.