Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thiserror-no-std with thiserror v2 #1628

Closed
DaniPopes opened this issue Nov 6, 2024 · 2 comments · Fixed by #1700
Closed

Replace thiserror-no-std with thiserror v2 #1628

DaniPopes opened this issue Nov 6, 2024 · 2 comments · Fixed by #1700
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.0

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Nov 6, 2024 •
edited
Loading

Component

other

Describe the feature you would like

thiserror released version 2 which includes no_std support: https://github.com/dtolnay/thiserror/releases/tag/2.0.0

thiserror must also be added with default-features = false

This requires MSRV 1.81: #1552

Additional context

No response
@DaniPopes DaniPopes added enhancement New feature or request good first issue Good for newcomers labels Nov 6, 2024
@nadtech-hub
Copy link
Contributor

🙋‍♂️

@zerosnacks zerosnacks added this to the 1.0 milestone Nov 18, 2024
@zerosnacks zerosnacks added the blocked This cannot move forward until something else changes label Nov 18, 2024
@zerosnacks
Copy link
Member

yay! unblocked by https://blog.rust-lang.org/2024/11/28/Rust-1.83.0.html

@zerosnacks zerosnacks removed the blocked This cannot move forward until something else changes label Nov 28, 2024
@DaniPopes DaniPopes mentioned this issue Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

chore(deps): bump thiserror 2 alloy-rs/alloy
3 participants
@nadtech-hub @DaniPopes @zerosnacks