Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eip1898): display RpcBlockHash #1242

Merged
merged 4 commits into from
Sep 5, 2024
Merged

chore(eip1898): display RpcBlockHash #1242

merged 4 commits into from
Sep 5, 2024

Conversation

emhane
Copy link
Contributor

@emhane emhane commented Sep 5, 2024 •
edited
Loading

Motivation

Closes #1206

Solution

Impl Display for RpcBlockHash and BlockId

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse merged commit ab630b8 into main Sep 5, 2024
29 checks passed
@mattsse mattsse deleted the emhane/display-block-id branch September 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] derive derive_more::Display for alloy_eips::eip1898::BlockId
2 participants
@emhane @mattsse