[Bug] Single-paremeter requests do not serialize correctly to array of items

[Evalir]

Component

json-rpc

What version of Alloy are you on?

latest

Operating System

macOS (Apple Silicon)

Describe the bug

When issuing single-parameter json-rpc requests to endpoints like eth_getBalance, it seems they are not serialized correctly to still send an array of params in JSON, failing with the following error: ErrorPayload { code: -32600, message: "Invalid json-rpc request", data: None }

The workaround is to make Params be a Vec<_>, but this should not be necessary.

[prestwich]

JSON-RPC2.0 spec is that params may be of arbitrary structure. the odd list encoding is ethereum-specific, and applies kinda unevenly across endpoints. Adding list-wrapping logic to the Request type would also cause some issues with Request<Box<RawValue>> I think?

This should probably be solved by adding a GetBalanceParams struct similar to this

struct GetBalanceParams {
    address: Address,
    height: Option<String>,
}

impl From<Address> for GetBalanceParams { ... }

impl Serialize for GetBalanceParams {
   fn serialize(s: S) {
     let seq = s.serialize_sequence();
     ...
  }
}

[prestwich]

closing as resolved