Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement conversion between signature types #1198

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Implement conversion between signature types #1198

merged 2 commits into from
Aug 28, 2024

Conversation

emhane
Copy link
Contributor

@emhane emhane commented Aug 26, 2024 •
edited
Loading

Motivation

Converting alloy_consensus::Transaction types into alloy_network_primitives::TransactionResponse types, requires conversion from alloy_primitives::Signature to alloy_rpc_types_eth::Signature

Solution

Implement From<alloy_primitives::Signature> for alloy_rpc_types_eth::Signature

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane added the debt Tech debt which needs to be addressed label Aug 26, 2024
@emhane emhane mentioned this pull request Aug 26, 2024
Closed
3 tasks
@emhane emhane requested a review from mattsse August 28, 2024 08:06
@mattsse mattsse merged commit e1489b7 into main Aug 28, 2024
26 checks passed
@mattsse mattsse deleted the emhane/signature branch August 28, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse