Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: rm 2930 and 7702 - use alloy-rs/eips #1181

Merged
merged 7 commits into from
Aug 28, 2024
Merged

refac: rm 2930 and 7702 - use alloy-rs/eips #1181

merged 7 commits into from
Aug 28, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Ref #1174.

Solution

2930 and 7702 have been extracted to a new repo - https://github.com/alloy-rs/eips. Use that and re-export in alloy-eips.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

crates/alloy/Cargo.toml Show resolved Hide resolved
crates/eips/Cargo.toml Outdated Show resolved Hide resolved
crates/eips/Cargo.toml Show resolved Hide resolved
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update the alloy eips readme to point to the new repo so people know where to look for the code

@yash-atreya
Copy link
Member Author

yash-atreya commented Aug 27, 2024

Bumping alloy-rs/eips further requires #1167, since it already uses alloy-primitives = "0.8"

@yash-atreya yash-atreya added the blocked This cannot move forward until something else changes label Aug 27, 2024
@yash-atreya yash-atreya removed the blocked This cannot move forward until something else changes label Aug 27, 2024
@mattsse mattsse merged commit 7968af7 into main Aug 28, 2024
26 checks passed
@mattsse mattsse deleted the yash/rm-eips branch August 28, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants