feat(transport): retry http errors with 503 status code #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkr8os
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
0xkr8os
force-pushed
the
transport-retry-503
branch
from
a22f754
to
3e5f85a
Compare
mattsse
requested changes
Aug 22, 2024
mattsse
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I received a 503 status code from Alchemy indicating the service was temporarily unavailable. This caused a long-running process to abort so naturally I started to add the RetryBackoffLayer functionality but noticed it only retried HTTP errors involving rate limits. The 503 status code represents a temporarily unavailable service and may even indicate when to try the request again making this error a good candidate to retry.
Solution
Return true in the
is_retry_errfunction when the status code is 503PR Checklist