Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion from BlockHashOrNumber to BlockId #1127

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add conversion from BlockHashOrNumber to BlockId #1127

merged 1 commit into from
Aug 5, 2024

Conversation

emhane
Copy link
Contributor

@emhane emhane commented Aug 5, 2024

Motivation

Implementing reth_rpc_eth_types::EthApiError paradigmxyz/reth#7416 (comment)

Solution

Adds conversion from alloy_eips::BlockHashOrNumber to alloy_eips::BlockId

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane mentioned this pull request Aug 5, 2024
Merged
11 tasks
@mattsse mattsse merged commit 68c8bfc into alloy-rs:main Aug 5, 2024
22 checks passed
@emhane emhane deleted the emhane/block-id-conversion branch August 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse