Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alloy_rpc_types_eth::SubscriptionResult generic over tx #1123

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

emhane
Copy link
Contributor

@emhane emhane commented Aug 3, 2024

Motivation

To plug into reth RPC, transaction type needs to be configurable at node builder level and adopted by all types further down, incl SubscriptionResult

Solution

Make SubscriptionResult generic over transaction

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we probably also want this to be generic over the header type eventually, so perhaps this should actually take a Network parameter instead?

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over log as well etc, but this would be a bigger change

@mattsse mattsse merged commit d370271 into alloy-rs:main Aug 5, 2024
22 checks passed
@harunfox72s
Copy link

Pi blockexplorerToggle navigation

الحسابJSON
المفتاح العام:
GAAKAAMFQ6REW3W3JUGQMRGBX27JQ3Z2E5RHD5CANFZO24H6YZ3MVZX4
مجال الصفحة الرئيسية:
عدد المدخلات الفرعية:
0
الأرصدة
المدفوعات
عروض
متاجرات
التأثيرات
العمليات
المعاملات
التوقيع
العلامات
البيانات
الصفحة اللاحقة →
النوع التفاصيل المعاملة الوقت
account_debited المبلغ: 250 Pi 4cd5c07... أول أمس JSON
account_credited المبلغ: 250 Pi 5027bf1... أول أمس JSON
account_debited المبلغ: 800 Pi a0a1667... قبل ٣ أيام JSON
account_credited المبلغ: 800 Pi 98c7c3e... قبل ٣ أيام JSON
account_debited المبلغ: 247 Pi ed962dc... قبل ٤ أيام JSON
account_credited المبلغ: 67 Pi 32cd256... قبل ٥ أيام JSON
account_credited المبلغ: 90 Pi 20ce3f3... قبل ٥ أيام JSON
account_credited المبلغ: 90 Pi f926178... قبل ٥ أيام JSON
account_debited المبلغ: 100 Pi 17c6ba0... قبل ٥ أيام JSON
account_credited المبلغ: 101 Pi 455e402... قبل ٨ أيام JSON
account_debited المبلغ: 101 Pi f96c037... قبل ٩ أيام JSON
account_credited المبلغ: 2 Pi 72a52a3... قبل ٩ أيام JSON
account_credited المبلغ: 99 Pi 0c170c3... قبل ٩ أيام JSON
account_credited المبلغ: 0.01 Pi a9af13b... قبل ١٢ يومًا JSON
account_debited المبلغ: 80 Pi 1b7a1af... قبل ١٢ يومًا JSON
account_credited المبلغ: 80 Pi d5c5242... قبل ١٢ يومًا JSON
account_debited المبلغ: 412 Pi c82eaa8... قبل ١٣ يومًا JSON
account_credited المبلغ: 105 Pi 03feec4... قبل ١٤ يومًا JSON
account_credited المبلغ: 150 Pi 191aaf0... قبل ١٤ يومًا JSON
account_credited المبلغ: 155 Pi c1a7b63... قبل ١٤ يومًا JSON
إ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants