Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccessListResult type (EIP-2930) #1110

Merged
merged 7 commits into from
Aug 1, 2024

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Jul 29, 2024

Towards #1109

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, one suggestion

crates/eips/src/eip2930.rs Outdated Show resolved Hide resolved
@mvares mvares requested a review from mattsse July 30, 2024 13:26
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits

crates/eips/src/eip2930.rs Show resolved Hide resolved
crates/eips/src/eip2930.rs Outdated Show resolved Hide resolved
crates/eips/src/eip2930.rs Outdated Show resolved Hide resolved
@mvares mvares requested a review from mattsse July 31, 2024 11:54
@mattsse mattsse force-pushed the access-list-result branch from dbb835f to 3295afc Compare August 1, 2024 17:00
@mattsse mattsse force-pushed the access-list-result branch from 3295afc to 02c84a0 Compare August 1, 2024 17:01
@mattsse mattsse merged commit 8e5a9fb into alloy-rs:main Aug 1, 2024
22 checks passed
@mvares mvares deleted the access-list-result branch August 1, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants