Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eip): make 7702 auth recovery fallible #1082

Merged

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

closes #1068

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, some suggestions

crates/eips/src/eip7702/auth_list.rs Outdated Show resolved Hide resolved
crates/eips/src/eip7702/auth_list.rs Outdated Show resolved Hide resolved
crates/eips/src/eip7702/auth_list.rs Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

cool, some suggestions

ty for your review boss, updated the changes (:

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last pedantic nits

crates/eips/src/eip7702/auth_list.rs Outdated Show resolved Hide resolved
crates/eips/src/eip7702/auth_list.rs Outdated Show resolved Hide resolved
crates/eips/src/eip7702/auth_list.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

@mattsse thank you for your review ! made all changes you requested :)

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

crates/eips/src/eip7702/auth_list.rs Outdated Show resolved Hide resolved
crates/eips/src/eip7702/auth_list.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

small nits

ty!

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse merged commit 7d67e9c into alloy-rs:main Jul 23, 2024
22 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* ake 7702 auth recovery fallible

* Update auth_list.rs

* Update auth_list.rs

* clippy

* clippy

* Update auth_list.rs

* Update crates/eips/src/eip7702/auth_list.rs

Co-authored-by: Matthias Seitz <[email protected]>

* Update auth_list.rs

* Update crates/eips/src/eip7702/auth_list.rs

Co-authored-by: Oliver <[email protected]>

* Update crates/eips/src/eip7702/auth_list.rs

Co-authored-by: Oliver <[email protected]>

* chore: add is fns

---------

Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] make 7702 auth recovery fallible
3 participants