chore(eip7702): devnet3 changes #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse,
prestwich and
Evalir
as code owners
onbjerg
force-pushed
the
onbjerg/eip7702-devnet2
branch
from
952bc24
to
507a775
Compare
mattsse
approved these changes
Jul 15, 2024
rakita
requested changes
Jul 15, 2024
onbjerg
force-pushed
the
onbjerg/eip7702-devnet2
branch
from
10ce80a
to
fb55716
Compare
onbjerg
force-pushed
the
onbjerg/eip7702-devnet2
branch
from
d3bba8c
to
fb55716
Compare
onbjerg
changed the title
OptionalNonce
onbjerg
changed the title
|
I think we should get this merged seeing as we are gunning for the current EIP7702 spec. Then, we'll merge #1059 as well. |
mattsse
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The nonce is no longer optional for devnet2.
Solution
Remove
OptionalNonceand make the nonce au64. Additionally, the chain ID is now aU256.This should not be merged before devnet3 (note: this used to be devnet2, but devnet2 will just be a reboot of devnet1 with fixes).
Closes #1048
PR Checklist