Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make auth mandatory in recovered auth #1047

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jul 13, 2024

optional authority if recovery failed doesn't make sense.

this should always be Address

Copy link
Contributor

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, this shouldn't be an option

@mattsse mattsse merged commit ea6a447 into main Jul 14, 2024
22 checks passed
@mattsse mattsse deleted the matt/fix-recoverd-auth-type branch July 14, 2024 12:23
@rakita
Copy link
Contributor

rakita commented Jul 16, 2024

Main point of Authority is it can be invalid, that was why it is made as a option

ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* chore: make auth mandatory in recovered auth

* features
j75689 pushed a commit to bnb-chain/alloy that referenced this pull request Aug 1, 2024
* chore: make auth mandatory in recovered auth

* features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants