Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS module handling needs to account for disabled thrusterTransforms #111

Open
gotmachine opened this issue Apr 20, 2022 · 2 comments
Open
Assignees
Labels

Comments

@gotmachine
Copy link

Note that I haven't looked at your code or tested how TCA handle RCS modules.
But FYI, since the introduction of the stock mesh-switchable RCS parts with variable nozzle configurations, it is now necessary to verify that a Transform entry in ModuleRCS.thrusterTransforms is actually enabled by checking transform.gameObject.activeInHierarchy.

@gotmachine gotmachine changed the title RCS potential torque need to account for disabled thrusterTransforms RCS module handling needs to account for disabled thrusterTransforms Apr 20, 2022
@allista allista self-assigned this Apr 20, 2022
@allista allista added the bug label Apr 20, 2022
@allista
Copy link
Owner

allista commented Apr 20, 2022

Thank you for reporting this one. I wonder if the engines need the same treatment?

@gotmachine
Copy link
Author

From a quick look I don't see a similar check in ModuleEngines, so I guess not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants