feat: add function to add Correlation IDs to logger #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmuralik
approved these changes
Mar 2, 2022
sgerogia
approved these changes
Mar 2, 2022
logging/correlation.go
Outdated
|
|
||
| correlationID, ok := ctx.Value(CorrelationIDName).(string) | ||
| if ok && len(correlationID) > 0 { | ||
| l = l.With(string(CorrelationIDName), correlationID) |
There was a problem hiding this comment.
Will this result in a constant GC overhead?
First instance created by With() is not used and is subject to GC.
The above happening for 1000s of requests.
There was a problem hiding this comment.
Are you saying we can combine the two With()s of this function? Probably yes, I can do it.
Also please do note that this is not a middleware so it's not called for each request, atm it will only be called by api-server in case of panics. I hope we won't have 1000s of panics 😂
There was a problem hiding this comment.
I avoided the intermediary logger and added unit tests. It should be fine now 😄
Pitasi
force-pushed
the
feat/add-correlationid-to-logger-util
branch
from
3b764dd to
1158d92
Compare
Pitasi
force-pushed
the
feat/add-correlationid-to-logger-util
branch
from
1158d92 to
f1b20a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function helps in preparing a new logger with correlation ID taken from http request context.