Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Upload QA models to HF #5494

Closed
4 tasks done
dirkgr opened this issue Dec 2, 2021 · 14 comments
Closed
4 tasks done

Upload QA models to HF #5494

dirkgr opened this issue Dec 2, 2021 · 14 comments
Assignees

Comments

@dirkgr
Copy link
Member

dirkgr commented Dec 2, 2021

  • bidaf
  • bidaf-elmo
  • transformer-qa
  • naqanet
@dirkgr dirkgr self-assigned this Dec 2, 2021
@dirkgr
Copy link
Member Author

dirkgr commented Dec 8, 2021

TransformerQA and Naqanet don't converge when training with the instructions in the demo :-(

@dirkgr
Copy link
Member Author

dirkgr commented Dec 8, 2021

@osanseviero, why did you write the push-to-hf command so that it renames the weights file to model.th? We expect best.th or better weights.th. Like this we don't load properly when I try to use hf:// URL.

@osanseviero
Copy link
Contributor

As discussed offline indeed this is an issue in the push-to-hf command. Fixing this is a minor change in the pushing script.

@dirkgr
Copy link
Member Author

dirkgr commented Dec 9, 2021

@osanseviero, I just uploaded a second version, and it did this: https://huggingface.co/allenai/bidaf/blob/main/README.md

That's probably not intended?

@osanseviero
Copy link
Contributor

Hi @dirkgr. The implementation of the push command respects the existing model card to avoid deleting user-written model card data or metadata, so it just adds the template before. We're working in some wrapper for the metadata that will include validation and allow merging metadata, but this is still not done. If you prefer, we can modify the command such that it does not add anything to the model card when there is already a model card, but moving forward we'll probably want to add things such as metrics to the metadata.

@github-actions
Copy link

@dirkgr this is just a friendly ping to make sure you haven't forgotten about this issue 😜

@dirkgr
Copy link
Member Author

dirkgr commented Jan 7, 2022

@dirkgr
Copy link
Member Author

dirkgr commented Jan 7, 2022

@osanseviero, the tensor board stuff is there, but it doesn't seem to render?

@dirkgr
Copy link
Member Author

dirkgr commented Jan 7, 2022

Ah, works in Chrome, not in Safari.

@osanseviero
Copy link
Contributor

@severo from the team is looking into it! 🤗

@severo
Copy link

severo commented Jan 7, 2022

It seems to be an error with the last version of tensorboard. I reported it here: tensorflow/tensorboard#5489.

@severo
Copy link

severo commented Jan 7, 2022

Fixed!

Capture d’écran 2022-01-07 à 18 10 43

Thanks for reporting

@dirkgr
Copy link
Member Author

dirkgr commented Jan 7, 2022

Thanks for fixing!

@dirkgr dirkgr closed this as completed Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants