Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate allenact/allenact_plugins tests. #272

Open
Lucaweihs opened this issue Apr 12, 2021 · 0 comments
Open

Separate allenact/allenact_plugins tests. #272

Lucaweihs opened this issue Apr 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Lucaweihs
Copy link
Collaborator

Problem

Currently our tests for allenact have dependencies on frameworks in allenact_plugins. Ideally these should be self contained.

Desired solution

Create test directories in allenact and allenact_plugins and create new tests in allenact that are not framework dependent.

Additional context

That this is a good idea was pointed out by @jordis-ai2 in #270 .
@Lucaweihs Lucaweihs added the enhancement New feature or request label Apr 12, 2021
@Lucaweihs Lucaweihs changed the title Separate allenact/allenact_plugins unit tests . Separate allenact/allenact_plugins tests. Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lucaweihs