-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue on creating new tag in gradle, local machine and github action #677
Comments
hi! |
Yes |
I have a similar issue even running the action on main directly. I do the release in the action, which creates/pushes the correct tags, but then publish adds snapshot to the artifacts Even tho the tags are in the repo and pushed do I need to fetch again before doing the gradle publish? |
@scprek do you create your release tasks using axion-release-plugin? |
So I believe the issue was me trying to be clever setting everything in Breaking the docs rule I believe
Maybe we should add an example of how to best do this when not applying the plugin at the root level. I wanted to avoid having any root versioning/artifacts and simply use the repo has a mono repo for a collection of modules. No BOM or anything (See my struggle trying to disable the root one in any other way besides not applying the plugin #694). Does this seem reasonable? Top level plugins {
id("pl.allegro.tech.build.axion-release") version "1.16.1" apply false
}
subprojects {
plugins.apply("pl.allegro.tech.build.axion-release")
tasks.withType<BaseAxionTask> {
version = versionConfig.version // <-- This only works with release NOT cV and publish whoops! Moved to each module
versionConfig.tag {
prefix.set(project.name)
versionSeparator.set("_")
}
versionConfig.branchVersionIncrementer.putAll(
mapOf<String, Any>(
"micronaut.*" to VersionProperties.Incrementer { c: VersionIncrementerContext -> c.currentVersion.incrementPatchVersion() }
)
)
}
} In
Result 🥳Tags Github Packges NO MORE SNAPSHOT!!!! |
I create a tag manually using github release tag and once the tag is created i see in github action the cV becomes snapshot.
Using latest v1.15.5
gradle-7.5
Issue here is after merging multiple feature, develop branches into main and then when i generate release tag this issue occurs.
If i do one commit directly to main then it works good and generates the given tag version.
The text was updated successfully, but these errors were encountered: