Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In some cases, seeing two responses from the bot #79

Closed
jakebolam opened this issue Jan 21, 2019 · 2 comments
Closed

In some cases, seeing two responses from the bot #79

jakebolam opened this issue Jan 21, 2019 · 2 comments
Assignees
Labels
bug Something isn't working released

Comments

@jakebolam
Copy link
Contributor

jakebolam commented Jan 21, 2019

Describe the bug
In some cases seeing two responses from the bot:
screen shot 2019-01-21 at 2 45 17 pm

To Reproduce
Steps to reproduce the behavior:

  1. @all-contributors please add @tbenning for design
    Repeat until seen

Expected behavior
One response per comment

Screenshots
See above

Additional context
The second error message is relating to: https://sentry.io/all-contributors/github-bot/issues/844367677/. I.e. the method is being invoked twice, and the second time fails on creating the branch. This is being fixed as part of #48. In this case tho it will still result in 2 comments to the users.

Looking at deliveries from GitHub there are 'service timeouts' at the time (with payload relating to this message), causing the double delivery.
screen shot 2019-01-21 at 2 50 11 pm

@jakebolam jakebolam added the bug Something isn't working label Jan 21, 2019
@jakebolam jakebolam changed the title In some cases, seeing dual responses from the bot In some cases, seeing two responses from the bot Jan 21, 2019
@jakebolam
Copy link
Contributor Author

jakebolam commented Jan 21, 2019

Lambda execution time:
screen shot 2019-01-21 at 3 06 23 pm

GitHub closes connections after 10 seconds, because we take longer than 10 seconds to return) GitHub is closing the connection (and possibly re-delivering?)

As the article says above we should probably: Favor asynchronous work over synchronous

We could have a lambda accepting request, and trigger another lambda when work is required, and return immediately on the main lambda.

@all-contributors-release-bot
Copy link
Member

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants