Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t create PR when contributor is already exist #345

Closed
rluvaton opened this issue Mar 3, 2021 · 4 comments · Fixed by #346
Closed

Don’t create PR when contributor is already exist #345

rluvaton opened this issue Mar 3, 2021 · 4 comments · Fixed by #346
Labels
enhancement New feature or request released

Comments

@rluvaton
Copy link
Contributor

rluvaton commented Mar 3, 2021

Is your feature request related to a problem? Please describe.
When a contribution been made by returning contributor and we ask a bot to add the contributor to the list it create an empty PR.

Describe the solution you'd like
What if when the bot is been asked to add a contributor it will check if the contributor is missing and only then it will add him, otherwise, it will replay with custom replay message or the default one “The user with this contribution type is already exist”

Flow:
Flow

@rluvaton rluvaton added the enhancement New feature or request label Mar 3, 2021
@gr2m
Copy link
Contributor

gr2m commented Mar 3, 2021

Thanks for opening the issue, I thought the app already did that today? Would you like to implement this?

@rluvaton
Copy link
Contributor Author

rluvaton commented Mar 3, 2021

Thanks for opening the issue,

Thank you for the quick replay!

I thought the app already did that today?

I though that too but goldbergyoni/nodebestpractices#903 is an example of creating a PR to add me as contributor when I already am.

Would you like to implement this?

I'll try to find some time

@rluvaton rluvaton changed the title Don’t create PR when contributed is already exist Don’t create PR when contributor is already exist Mar 3, 2021
@rluvaton
Copy link
Contributor Author

rluvaton commented Mar 4, 2021

@gr2m done - #346 😄

@gr2m gr2m closed this as completed in #346 Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants