Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge multiple contributors in a single comment #241

Closed
zeke opened this issue Aug 30, 2019 · 3 comments · Fixed by #127
Closed

Acknowledge multiple contributors in a single comment #241

zeke opened this issue Aug 30, 2019 · 3 comments · Fixed by #127
Assignees
Labels
enhancement New feature or request

Comments

@zeke
Copy link

zeke commented Aug 30, 2019

👋 First off, I just want to say this project is really awesome!

I just set it up on repo-sync/repo-sync#8 and I can't believe It Just Works™! I also guessed at the formatting for my comment @all-contributors please add @wei for design and code and docs and that worked as well. That compromise NLP tool looks really handy too.

Anyway, on to the feature request!

Is your feature request related to a problem? Please describe.

I would like to set up all-contributors on a new project, and I want to acknowledge a bunch of existing contributors right away in a single comment.

Describe the solution you'd like

I'd like to be able to type a comment like this:

@all-contributors please add @hermione for ideas and code, @ron for questions, and @harry for docs and tooling.

Describe alternatives you've considered

I could just type multiple individual comments:

@all-contributors please add @hermione for ideas and code
@all-contributors please add @ron for questions
@all-contributors please add @harry for docs and tooling

.. but I'm afraid that could lead to multiple PRs with merge conflicts?

Additional context

I haven't tried any of this out yet, but took at look at the tests in https://github.com/all-contributors/all-contributors-bot/blob/69adf07f4625be6917887e56313fd34288b35591/test/tasks/processIssueComment/utils/parse-comment/index.test.js and didn't see any existing tests for these kinds of strings.

@zeke zeke added the enhancement New feature or request label Aug 30, 2019
@js-kyle
Copy link
Contributor

js-kyle commented Aug 31, 2019

I agree, it would be helpful! It's a WIP over in #127

@kkrieger85
Copy link

+1 for this request

@tenshiAMD tenshiAMD linked a pull request Sep 28, 2022 that will close this issue
@tenshiAMD
Copy link
Member

PR #127 is almost done. Closing this one for now.

@tenshiAMD tenshiAMD self-assigned this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants