Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding multiple users in a single message (Use NLP parsing per sentence, not on an entire message) #100

Closed
jakebolam opened this issue Jan 25, 2019 · 3 comments · Fixed by #127
Closed

Support adding multiple users in a single message (Use NLP parsing per sentence, not on an entire message) #100

jakebolam opened this issue Jan 25, 2019 · 3 comments · Fixed by #127
Assignees
@jakebolam
Labels
enhancement New feature or request released

Comments

@jakebolam
Copy link
Contributor

jakebolam commented Jan 25, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
It would be great to have a way to bulk add users in a single request.

Describe the solution you'd like
Implementing per sentence parsing instead of per-message will allow us to do this. It will also help the NLP to be more effective in determining intentions.

Describe alternatives you've considered

Additional context
Case of a user adding lots of users: zeroDevs/FullstackTrends_Challenge-13#161

Broken case on message too big:
https://github.com/zeroDevs/coding_challenge-13/issues/132#issuecomment-457773736
screen shot 2019-01-25 at 6 48 53 pm

Case of not working:
See freecodecamp-ibadan/freecodecamp-ibadan#4

@all-contributors please add @stevoo24 for code,content

screen shot 2019-02-10 at 11 30 04 am
@jakebolam jakebolam added the enhancement New feature or request label Jan 25, 2019
@jakebolam jakebolam mentioned this issue Jan 25, 2019
Merged
@jakebolam jakebolam mentioned this issue Jan 29, 2019
Merged
This was referenced Feb 4, 2019
Closed
Closed
@jakebolam jakebolam mentioned this issue Mar 22, 2019
Open
@jakebolam jakebolam self-assigned this Mar 22, 2019
@jakebolam
Copy link
Contributor Author

PR in progress: #127

@samajammin samajammin mentioned this issue Nov 22, 2019
Closed
@thatrobotdev thatrobotdev mentioned this issue May 5, 2020
Closed
@tenshiAMD
Copy link
Member

PR #127 is almost done. Closing this one for now.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🎉 This issue has been resolved in version 1.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakebolam jakebolam

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support adding multiple users in a single message all-contributors/app
3 participants
@jakebolam @tenshiAMD and others