Error while adding user with - in the name

[Wei-1]

Describe the bug
The bot add @wei instead of @Wei-1 while using the command in a PR.

To Reproduce
Steps to reproduce the behavior:

1. Go to any repo with @all-contributors bot
2. Use @all-contributors please add Wei-1 for maintenance
3. Check the PR created by @all-contributors bot
4. See that it add @wei instead of @Wei-1

Expected behavior
It should add @Wei-1 instead

Screenshots
Curt-Park/rainbow-is-all-you-need#12

Additional context
Probably caused by - sign

[marekrozmus]

@Wei-1 bot needs @ before user name. Had same problem - check here: all-contributors/cli#225 (comment)

So you should use: Use @all-contributors please add @Wei-1 for maintenance and it should work correctly.

[allcontributors]

@marekrozmus

I've put up a pull request to add @Wei-1! 🎉

[marekrozmus]

@Wei-1 as you can see above ;)

Please somebody delete that PR :D

BTW: How did you manage to create this issue without genrating new bot PR :) ?

[Wei-1]

That's a very good question @marekrozmus I have no idea though..
btw, should we close this issue?

[Klaas-]

I think there is still an issue with "-" see this:
ComplianceAsCode/content#5355 (comment)
And it created ComplianceAsCode/content#5480

[baikho]

@Wei-1 as you can see above ;)

Please somebody delete that PR :D

BTW: How did you manage to create this issue without genrating new bot PR :) ?

I think that's because the issue / PR needs to exist before quoting the bot, see all-contributors/all-contributors#380 (comment)

[baikho]

I believe this needs fixing in parseAddComment(), but on a side note; GitHub won't let you register such account names (anymore?) as per:

Username may only contain alphanumeric characters or single hyphens, and cannot begin or end with a hyphen.

[jakebolam]

Thank you @Wei-1

[jakebolam]

Fixed in #307

[Klaas-]

Does that make my username valuable? :) thanks for fixing @baikho