forked from excalidraw/excalidraw
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste Elements always as Elements even if we are writting in a textarea #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed in favor of #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App.tsx:2244
it checks if we are about to paste inside a text area and if so, it just returns from this function.App.tsx:2260
excalidraw parses the clipboard data and it may return valid excalidrawelements
.let file = ...
inApp.tsx:2263
is there because they were losing files from the clipboard because of... the comment tries to explain it...parseClipboardEvent
andparseClipboard
wereasync
functions but they didn't have anyawait
inside them.let file
at all... I have moved those 2 lines together anyway to avoid more refactoring, but the only thing I need is to parse the clipboard content to see if there are elements inside and not return if so.This may not be a full/proper solution so I have created an
@alkemio/excalidraw
package version@0.17.0-alkemio-3-beta
to test it properly