Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swallow_errors bad behavior with limit with option deduct_when as… #364

Conversation

tlauga
Copy link
Contributor

@tlauga tlauga commented Oct 25, 2022

Fix swallow_errors bad behavior with limit with option deduct_when as issue #363

Ticket: SEO-739

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 100.00% // Head: 99.53% // Decreases project coverage by -0.46% ⚠️

Coverage data is based on head (315fa27) compared to base (6c96612).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #364      +/-   ##
===========================================
- Coverage   100.00%   99.53%   -0.47%     
===========================================
  Files            7        7              
  Lines          857      862       +5     
===========================================
+ Hits           857      858       +1     
- Misses           0        4       +4     
Impacted Files Coverage Δ
flask_limiter/extension.py 98.87% <33.33%> (-1.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alisaifee
Copy link
Owner

Looks about right to me, thanks for the PR!
I'll take care of the dropped test coverage.

@alisaifee alisaifee self-requested a review October 25, 2022 20:03
@alisaifee alisaifee merged commit 51a12da into alisaifee:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants