Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide way to auto include system parameters for each resource stack identifier #1

Open
alidcast opened this issue Apr 6, 2020 · 0 comments

Comments

@alidcast
Copy link
Owner

alidcast commented Apr 6, 2020

thinking about possible API for this.

My first thought was to add a Options property in template map that lets user enable the auto inclusion of system parameter resources:

{#eid :StackName 
 {:Options      {:SystemParameters true}
  :Resources  {:MyResource [:Service.Module {}]} }}

But I dislike that I'm mixing infra properties into a map that should consistent of only AWS Cloudformation options.

So a better alternative may be to stick with reader literals for config manipulation. We can add a #with-params literal that does serves same purpose as above option:

{#eid :StackName 
 #with-params {:MyResource [:Service.Module {}]} }

With this alternative, I dislike that this reader literal is only meant to be used in a single context (when declaring resource options). But I guess that's OK since the scope of this reader is for AWS templates.


Another concern, that might make this more cumbersome, is that resources are mapped based on their logical identifiers (local to stack) not their physical identifiers (global to user's aws account). But perhaps I can just use AWS's ref templating utility so that identifier strings can be replaced by AWS at creation time.

alidcast added a commit that referenced this issue Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant