Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mprovements + change integration test name #362

Closed
wants to merge 2 commits into from

Conversation

wszaranski
Copy link
Contributor

Make improvements

  • removed reduntant integration Makefile
  • changed "integration" target to run only integration tests
    this should speed up CI tests because they wont run unit tests twice
    (in testrace and again in int target)
  • added help target to list available targets to be used by user
  • added target to download and build redis server
    server will be downloaded and build if it's not available
    when version in get_redis.sh will be changed new server will be
    downloaded and build automatically even if previous version was
    available locally

Change integration test name to conformance

Integration tests test application code/module together with other
software. In case of miniredis there is no connection between miniredis
code and original redis. Vanilla Redis is used in tests only as source
of truth (basically as part of the test code not tested application).
Conformance test name should be more obvious in this case.


NOTE: it's my personal opinion, that in case of miniredis, "integration" test is a little misleading name and "conformance" might be a better one. I don't have strong opinion on this, so if you prefer to keep old name, don't hesitate to drop this commit without any comments :)

- removed reduntant integration Makefile
- changed "integration" target to run only integration tests
  this should speed up CI tests because they wont run unit tests twice
  (in `testrace` and again in `int` target)
- added help target to list available targets to be used by user
- added target to download and build redis server
  server will be downloaded and build if it's not available
  when version in get_redis.sh will be changed new server will be
  downloaded and build automatically even if previous version was
  available locally

Signed-off-by: Wojciech Szarański <[email protected]>
Integration tests test application code/module together with other
software. In case of miniredis there is no connection between miniredis
code and original redis. Vanilla Redis is used in tests only as source
of truth (basically as part of the test code not tested application).
Conformance test name should be more obvious in this case.

Signed-off-by: Wojciech Szarański <[email protected]>
@alicebob alicebob mentioned this pull request Mar 23, 2024
alicebob added a commit that referenced this pull request Mar 23, 2024
* Make improvements
---------

Signed-off-by: Wojciech Szarański <[email protected]>
Co-authored-by: Wojciech Szarański <[email protected]>
@alicebob
Copy link
Owner

Hi! Thanks for the updates. I did not use all.

  • I prefer to not have to configure my editor much, and expect make to do something sane. Which is often go test, so I keep running make doing just that. Same reason there's a Makefile in integration: then I can run my "run make" button in my editor and it'll do the right thing.
  • the redis binary doesn't have to come from the local copy. If there's a redis-server in the path the tests will use that one. So you can download a binary and don't have to build from source.
  • renaming integration to something more useful you're are completely right about, but it has been like this forever and it doesn't seem worth the trouble.

@alicebob alicebob closed this Mar 23, 2024
@wszaranski wszaranski deleted the improvements branch April 9, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants