Make mprovements + change integration test name #362
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make improvements
this should speed up CI tests because they wont run unit tests twice
(in
testrace
and again inint
target)server will be downloaded and build if it's not available
when version in get_redis.sh will be changed new server will be
downloaded and build automatically even if previous version was
available locally
Change integration test name to conformance
Integration tests test application code/module together with other
software. In case of miniredis there is no connection between miniredis
code and original redis. Vanilla Redis is used in tests only as source
of truth (basically as part of the test code not tested application).
Conformance test name should be more obvious in this case.
NOTE: it's my personal opinion, that in case of miniredis, "integration" test is a little misleading name and "conformance" might be a better one. I don't have strong opinion on this, so if you prefer to keep old name, don't hesitate to drop this commit without any comments :)