-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add cases for testing imageCache.get #979
test: add cases for testing imageCache.get #979
Conversation
@faycheng if working your pr in process, you can add prefix [WIP] in your pr title. Thanks a lot. |
@HusterWan Done. |
@faycheng please rebase your PR, thanks :) |
Signed-off-by: 程飞 <[email protected]>
146fb3a
to
92fe150
Compare
@YaoZengzeng Done. Travis log:
|
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 13.04% 13.09% +0.04%
==========================================
Files 124 124
Lines 8354 8354
==========================================
+ Hits 1090 1094 +4
+ Misses 7171 7168 -3
+ Partials 93 92 -1
Continue to review full report at Codecov.
|
Remove the WIP label |
LGTM |
Signed-off-by: 程飞 [email protected]
Ⅰ. Describe what this PR did
add cases for testing
imageCache.get
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
this pr is related to issue #975 & pr #973 .please don't merge it before merging #973
Ⅳ. Describe how to verify it
make unit-test
Ⅴ. Special notes for reviews