Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cases for testing imageCache.get #979

Merged

Conversation

faycheng
Copy link
Contributor

Signed-off-by: 程飞 [email protected]

Ⅰ. Describe what this PR did

add cases for testing imageCache.get

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

this pr is related to issue #975 & pr #973 .please don't merge it before merging #973

Ⅳ. Describe how to verify it

make unit-test

Ⅴ. Special notes for reviews

@faycheng faycheng changed the title add image get test test: add cases for testing imageCache.get Mar 27, 2018
@HusterWan
Copy link
Contributor

@faycheng if working your pr in process, you can add prefix [WIP] in your pr title. Thanks a lot.

@faycheng faycheng changed the title test: add cases for testing imageCache.get [WIP] test: add cases for testing imageCache.get Mar 27, 2018
@faycheng
Copy link
Contributor Author

@HusterWan Done.

@YaoZengzeng
Copy link
Contributor

@faycheng please rebase your PR, thanks :)

Signed-off-by: 程飞 <[email protected]>
@faycheng faycheng force-pushed the add-image-get-test branch from 146fb3a to 92fe150 Compare March 27, 2018 13:18
@faycheng
Copy link
Contributor Author

@YaoZengzeng Done.
And in order to trigger travis ci again, i will mark this pr closed and then mark it opened.

Travis log:

> sudo apt-get update -qq
W: The repository 'http://www.apache.org/dist/cassandra/debian 39x Release' does not have a Release file.
W: http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/Release.gpg: Signature by key 15866BAFD9BCC4F3C1E0DFC7D69548E1C17EAB57 uses weak digest algorithm (SHA1)
E: Failed to fetch http://dl.bintray.com/apache/cassandra/dists/39x/main/binary-amd64/Packages  502  Bad Gateway [IP: 52.27.175.225 80]
E: Failed to fetch http://dl.bintray.com/apache/cassandra/dists/39x/main/binary-i386/Packages  502  Bad Gateway [IP: 52.27.175.225 80]
E: Some index files failed to download. They have been ignored, or old ones used instead.
The command "sudo apt-get update -qq" failed and exited with 100 during .

@faycheng faycheng closed this Mar 27, 2018
@faycheng faycheng reopened this Mar 27, 2018
@codecov-io
Copy link

Codecov Report

Merging #979 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   13.04%   13.09%   +0.04%     
==========================================
  Files         124      124              
  Lines        8354     8354              
==========================================
+ Hits         1090     1094       +4     
+ Misses       7171     7168       -3     
+ Partials       93       92       -1
Impacted Files Coverage Δ
daemon/mgr/image.go 32.12% <0%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c936270...92fe150. Read the comment docs.

@faycheng faycheng changed the title [WIP] test: add cases for testing imageCache.get test: add cases for testing imageCache.get Mar 27, 2018
@faycheng
Copy link
Contributor Author

Remove the WIP label

@YaoZengzeng
Copy link
Contributor

LGTM

@YaoZengzeng YaoZengzeng merged commit 634a0cc into AliyunContainerService:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants