Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #904

Merged
merged 1 commit into from
Mar 16, 2018
Merged

docs: fix typo #904

merged 1 commit into from
Mar 16, 2018

Conversation

renlulu
Copy link
Contributor

@renlulu renlulu commented Mar 15, 2018

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @renlulu
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

@renlulu Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @renlulu
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #904   +/-   ##
=====================================
  Coverage      14%    14%           
=====================================
  Files         119    119           
  Lines        7477   7477           
=====================================
  Hits         1047   1047           
  Misses       6341   6341           
  Partials       89     89
Impacted Files Coverage Δ
cli/top.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc6fa0...b022d77. Read the comment docs.

@HusterWan
Copy link
Contributor

@renlulu very appreciative of your work, please sign the CLA, thanks a lot

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 16, 2018
@allencloud allencloud merged commit 0a3508e into AliyunContainerService:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs areas/typo LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants