feature: wrap cri manager to log every cri operation #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YaoZengzeng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
- Coverage 14.37% 13.93% -0.44%
==========================================
Files 117 118 +1
Lines 7104 7328 +224
==========================================
Hits 1021 1021
- Misses 5996 6220 +224
Partials 87 87
Continue to review full report at Codecov.
|
|
@allencloud PTAL. |
Letty5411
reviewed
Mar 15, 2018
| @@ -81,18 +81,20 @@ type CriManager struct { | |||
| } | |||
|
|
|||
| // NewCriManager creates a brand new cri manager. | |||
| func NewCriManager(config *config.Config, ctrMgr ContainerMgr, imgMgr ImageMgr) (*CriManager, error) { | |||
| func NewCriManager(config *config.Config, ctrMgr ContainerMgr, imgMgr ImageMgr) (CriMgr, error) { | |||
There was a problem hiding this comment.
How about change CriMgr to CriMgrWrap
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
This PR logs every operation of cri manager and it will be more convenient for us to debug :)
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews