Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add deamon related function #884

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

Letty5411
Copy link
Contributor

@Letty5411 Letty5411 commented Mar 13, 2018

Signed-off-by: letty [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix #848

Ⅲ. Describe how you did it

In order to support pouch daemon test, add test/daemon package.
For each daemon test, start a pouch daemon with a test listenaddress and home dir.
So it will coexists with the default pouch daemon.

Also naming the daemon related tests files with prefix z-, they will be executed in the end.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Letty5411 Letty5411 force-pushed the daemon-test branch 4 times, most recently from 382bb8f to 8cc70b4 Compare March 13, 2018 08:20
@Letty5411 Letty5411 changed the title [WIP] test: add deamon related function test: add deamon related function Mar 13, 2018
@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #884 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   14.37%   14.56%   +0.18%     
==========================================
  Files         117      115       -2     
  Lines        7104     7012      -92     
==========================================
  Hits         1021     1021              
+ Misses       5996     5904      -92     
  Partials       87       87
Impacted Files Coverage Δ
client/container.go 0% <0%> (ø) ⬆️
cli/cli.go 0% <0%> (ø) ⬆️
cli/main.go 0% <0%> (ø) ⬆️
daemon/mgr/image_utils.go 0% <0%> (ø) ⬆️
daemon/mgr/system.go 0% <0%> (ø) ⬆️
cli/top.go
cli/info.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3764a1e...35011cc. Read the comment docs.

@Letty5411 Letty5411 changed the title test: add deamon related function [WIP] test: add deamon related function Mar 13, 2018
@Letty5411 Letty5411 force-pushed the daemon-test branch 3 times, most recently from c9d9a7c to 8c2668c Compare March 13, 2018 09:53
@Letty5411 Letty5411 changed the title [WIP] test: add deamon related function test: add deamon related function Mar 13, 2018
@Letty5411 Letty5411 force-pushed the daemon-test branch 6 times, most recently from 48ba071 to 06269ec Compare March 15, 2018 03:32
@HusterWan
Copy link
Contributor

LGTM, thanks for you great work @Letty5411

@HusterWan HusterWan merged commit 3391aa8 into AliyunContainerService:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test request] need to support pouch daemon test
4 participants