Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Print error log in CI. #883

Merged
merged 1 commit into from
Mar 13, 2018
Merged

[test] Print error log in CI. #883

merged 1 commit into from
Mar 13, 2018

Conversation

sunyuan3
Copy link
Contributor

@sunyuan3 sunyuan3 commented Mar 13, 2018

Signed-off-by: Yuan Sun [email protected]

Ⅰ. Describe what this PR did

Print error log in CI. Don't redirect the error log to a file.

Ⅱ. Does this pull request fix one issue?

Yes. CI did miss some error logs. We need to print these logs.

Ⅲ. Describe how you did it

Print error log in CI.

Ⅳ. Describe how to verify it

NA

Ⅴ. Special notes for reviews

NA

@sunyuan3 sunyuan3 requested a review from Letty5411 March 13, 2018 01:43
@sunyuan3 sunyuan3 changed the title [test] print log when test is failed [test] print error log Mar 13, 2018
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Mar 13, 2018
@sunyuan3 sunyuan3 changed the title [test] print error log [test] Print error log in CI. Mar 13, 2018
@codecov-io
Copy link

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   14.62%   14.62%           
=======================================
  Files         115      115           
  Lines        6940     6940           
=======================================
  Hits         1015     1015           
  Misses       5839     5839           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c2f20...bea30d9. Read the comment docs.

@sunyuan3
Copy link
Contributor Author

This PR isn't the root cause of the CI failure.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 13, 2018
@Letty5411
Copy link
Contributor

@sunyuan3 please change the commit message to : test:xxx

@sunyuan3
Copy link
Contributor Author

@Letty5411 Done.

@Letty5411 Letty5411 merged commit 16217f5 into AliyunContainerService:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/log areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants