feature: add container top interface #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since #881 has been merged, please rebase to the latest branch and push back again. Thanks. @HusterWan |
HusterWan
force-pushed
the
zr/add-top-interface
branch
3 times, most recently
from
0438216 to
34aea35
Compare
Signed-off-by: Michael Wan <[email protected]>
HusterWan
force-pushed
the
zr/add-top-interface
branch
from
34aea35 to
7c6890c
Compare
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 14.62% 14.55% -0.07%
==========================================
Files 115 116 +1
Lines 6940 6973 +33
==========================================
Hits 1015 1015
- Misses 5839 5872 +33
Partials 86 86
Continue to review full report at Codecov.
|
allencloud
reviewed
Mar 13, 2018
|
|
||
| container := args[0] | ||
|
|
||
| arguments := args[1:] |
There was a problem hiding this comment.
You add Args: cobra.ExactArgs(1),
So arguments := args[1:] is meaningless.
I think inconsistency happens.
Please correct this in the following PR.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
add top interface
Ⅱ. Does this pull request fix one issue?
fixes #867
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews