Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: skeleton of upgrade interface #852

Merged

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: HusterWan [email protected]

Ⅰ. Describe what this PR did

add skeleton of pouch upgrade interface

Ⅱ. Does this pull request fix one issue?

fixes part of #823

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@HusterWan HusterWan force-pushed the zr/add-upgrade-interface branch 2 times, most recently from f6faefd to 86d2d98 Compare March 9, 2018 02:27
@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #852 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #852      +/-   ##
=========================================
- Coverage   14.88%   14.8%   -0.08%     
=========================================
  Files         114     115       +1     
  Lines        6821    6857      +36     
=========================================
  Hits         1015    1015              
- Misses       5720    5756      +36     
  Partials       86      86
Impacted Files Coverage Δ
cli/main.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 2.79% <0%> (-0.01%) ⬇️
cli/upgrade.go 0% <0%> (ø)
client/container.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d8e1a...60c173d. Read the comment docs.

@Letty5411
Copy link
Contributor

@HusterWan Could you add a skeleton of test, like api_upgrade_test.go and cli_upgrade_test.go.

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 12, 2018
@allencloud allencloud merged commit b2ac56a into AliyunContainerService:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants