Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix code issue brought by 660 #675

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun [email protected]

1.Describe what this PR did

I merged #660 , while @YaoZengzeng found that there are some code needed improvement. So I submit a PR to fix this.

2.Does this pull request fix one issue?
NONE

3.Describe how you did it
NONE

4.Describe how to verify it
NONE

5.Special notes for reviews
NONE

@codecov-io
Copy link

Codecov Report

Merging #675 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   10.16%   10.15%   -0.01%     
==========================================
  Files          71       71              
  Lines        3425     3427       +2     
==========================================
  Hits          348      348              
- Misses       3038     3040       +2     
  Partials       39       39
Impacted Files Coverage Δ
cli/container.go 25.92% <0%> (-0.33%) ⬇️
cli/run.go 0% <0%> (ø) ⬆️
cli/create.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62aada5...8cb574c. Read the comment docs.

@YaoZengzeng
Copy link
Contributor

LGTM.

@allencloud allencloud merged commit d527f57 into AliyunContainerService:master Feb 1, 2018
@allencloud allencloud deleted the fix-660 branch February 1, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants